ContainsCondition: use case of attribute byLine

Description

From the documentation

Name

Description

byLine

Whether to look up an entry on each line separately or just on a compact content.
This makes sense especially for file contents and regular expression patterns, but applies on all combinations of sources.

Conflicts:

  1. The code shows, that byLine is used for regex="true" only. This is in contrast to the documentation above. Is this intented? I do not think so.

  2. With byLine="true": Should the condition be true, when the pattern is found in at least one of the lines or in all lines? This should be defined

Environment

None

Activity

Show:
René Krell
May 23, 2016, 7:28 PM

Because beginning with version 5.0.9 the pattern does find substrings also. And it will find the same substring both with byLine="true" and byLine="false".
I would suggest to remove all code for the attribute byLine in version 5.0.9, but still allow the attribute in the XSD, so that existing installers are still valid. The attribute should be removed from the XSD on 5.1 or some later version.

I agree with removing the attribute, but I would not leave anything in the XSD which is not functional any longer.
I vote vor removing it also from the XSD and adding this fact clearly to the release announcement. To fix installers which were using this is really a small effort. This can happen also for other cases, for instance to remove workarounds of things that have been fixed.
I don't like keeping dead stuff hanging around if it doesn't help anyone any longer.
Thank you for cleaning this up.

Tom Helpstone
May 24, 2016, 10:22 AM

One thought about cleaning up immediatly: When removing byLine from the xsd, this will be removed from http://izpack.org/schema/5.0/izpack-installation-5.0.xsd also?
Users with 5.0.7 and 5.0.8 may still need byLine="true". So the schema provided for XML-Validation in the editor maybe should not mark this as an error? Is this a reason to delay cleanup of xsd to 5.1?

René Krell
May 24, 2016, 10:25 AM
Edited

One thought about cleaning up immediatly: When removing byLine from the xsd, this will be removed from http://izpack.org/schema/5.0/izpack-installation-5.0.xsd also?
Users with 5.0.7 and 5.0.8 may still need byLine="true". So the schema provided for XML-Validation in the editor maybe should not mark this as an error? Is this a reason to delay cleanup of xsd to 5.1?

This is not a problem, because the XSD is always built-in to each version. There is no reason for looking back at older versions. Compiling is based on the XSDs the compiler of the dedicated version contains.
The only concern is for the copy od the XSDs at the website, but there we leave always the latest changes. If anyone gets a problem with a validating editor in worst case there is the chance to deactivate validating, better to update.
Absolutely no concerns as far as I can see.

Tom Helpstone
May 24, 2016, 12:08 PM
Edited

Ok! I've sent pull request 519 and updated documentation on https://izpack.atlassian.net/wiki/display/IZPACK/Contains+Condition

René Krell
May 30, 2016, 1:30 PM

Merged PR #519.

Fixed

Assignee

René Krell

Reporter

Tom Helpstone

Impact

None

Components

Sprint

None

Fix versions

Affects versions

Priority

Medium
Configure