Attribute "regroot" for dynamic variable is not documented

Description

The attribute regroot is not documented on https://izpack.atlassian.net/wiki/display/IZPACK/Dynamic+Variables.
Because it seems to be not functional at the moment, the documentation should be delayed until feature does work. See

Environment

None

Activity

Show:
Zdeněk Vaník
June 27, 2016, 2:55 PM

From the analysis it seems that regroot is no longer needed, it was used previously when reg query command was ran (there you have to specify separate root and key), now it seems that you do not need that at all, for registry values commands reg export to get the key and reg import to create the key are ran. They either require absolute path and/or registry file respectively.
So I would suggest to get rid of the regroot attribute completely.
Also another note, when I used double backslashes in regkey attribute it could not get the key for me though it is described so in the documentation.

René Krell
June 27, 2016, 3:03 PM

Personally I'd agree to remove the meaning less attribute regroot from XSD and its processing from the code.
This attribute has been probably forgotten after the migration to reg export. From my remembering, the change from reg query to reg export has been done for the reason of getting the proper encoding (the registry is encoded in UTF-16). This change can't be even found in the Git history (has been merged from the original ini4j project).

René Krell
March 13, 2017, 2:31 PM

Flag added

Candidate for the next bug fix release after 5.1.0.

Zdeněk Vaník
March 20, 2017, 1:44 PM

I took the liberty to remove the attribute in PR #594.

René Krell
March 21, 2017, 10:46 AM

Thanks for this contribution.

Flagged

Assignee

Zdeněk Vaník

Reporter

Tom Helpstone

Impact

Functional - may break existing environments

Components

Sprint

None

Fix versions

Affects versions

Priority

Low
Configure