Uploaded image for project: 'IzPack'
  1. IzPack
  2. IZPACK-799

PackSelectionCondition uses the wrong pack attribute

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: 5.0
    • Fix Version/s: 5.0
    • Component/s: Installer
    • Labels:
      None

      Description

      The PackSelectionCondition class, and its use in RulesEngineImpl.initStandardConditions() use the Pack.id attribute to identify packs.
      This is the wrong attribute. Pack.id is the localisation identifier, and is optional. Its supposed to be used to derive a pack name for the current locale.
      PackSelectionCondition should be using Pack.name instead.

      The reason it works currently is due to some code in Packager that assigns Pack.name to Pack.id if the id is null.

        Attachments

          Activity

          There are no comments yet on this issue.

            People

            • Assignee:
              timanderson Tim Anderson
              Reporter:
              timanderson Tim Anderson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: