Modifying an existing installation clears checkboxes of already installed packages by default

Description

Proposed patch attached, the building of existing packages is done too early. Apologies, I am unable to clone the repo to do a proper pull request, this is based on the 5.2.0 code base

Environment

None

Attachments

2

Activity

Show:

JP January 31, 2024 at 7:24 AM

thank you for your time analyzing this, yes indeed the problem is the checkboxes are being reset systematically on a modified installation. This caused me headaches as I ended up with partial upgrades in production unknowingly.

Apologies for not returning to you earlier with a sample, I did not notice that side effect on installing all packages then upgrading them, must not have had the use case, understood.

Maybe we can add an extra string column in the Packs panel table describing grayed packages with a status: Installed/Required? That way no need for the Note on top explaining the grayed packages. I am not sure how all this would translate on the command line though.

Hitesh A. Bosamiya January 30, 2024 at 12:10 PM
Edited

, looking at the code changes, I think what you are talking about is clearing of checkboxes not the actual package content. Hence changing the title appropriately. Attaching example which reproduces this behavior. With the suggested changes, it keeps the packs selected (the checkboxes) but allows you to uncheck, which can be confusing for the user. We need a mechanism in which the user gets an indication on already installed packages.

Run the attached example with “New installation” with Pack 1 and Pack 2 selected then “Modify installation”, you will see that Pack 1 and Pack 2 checkboxes are cleared, disabled and greyed. Once all the 3 packs are installed then with “Modify installation” the next button is greyed out user does not even know why it remains grey!

Hitesh A. Bosamiya January 20, 2024 at 7:04 AM

@JP, can you please attach an example to reproduce the issue?

Details

Assignee

Reporter

Affects versions

Priority

Created January 13, 2024 at 4:26 PM
Updated February 2, 2024 at 6:49 AM