...
- Look at the code carefuly to ensure that it is of good quality
- Obviously... test it
- Attach your review to the related JIRA issue
- Send your review to the dev mailing-list if needed.
In case no other developer makes a comment after a few days, you can act as you decided: accept or reject it!
...
- Always create a JIRA issue in case of bug, improvement or new feature. You can follow progess of your issue there.
- If you have a patch, then attach it to the JIRA issue.
- Do not hesitate to attach screenshots and stack traces.
- Make sure you send a real diff-generated patch, not whole files or ZIPs with the modified files... (Several programs will generate this, for example: IntelliJ, Eclipse, Netbeans, TortoiseSVN,...)
- Should you propose a new feature, make sure to attach documentation. Ideally you will have a patch for the documentation, but plain text will also do.
- Subscibe to the developer mailing list if you want to follow IzPack development conversations.
- Respect code format styles! Otherwise we have a hard time trying to merge your code.
Code formatting
The src folder in the IzPack source code contains code style settings for Eclipse and IntelliJ IDEA.
Everyone has its own preferences, so to make everyone comfortable, here are a few things to respect.
...